StrokesPlus Forum
                       
StrokesPlus Forum
Home | Profile | Register | Active Topics
Members | Search | FAQ
Username:
Password:
Save Password
Forgot your Password?

 All Forums
 Bug and Issues
 Known Issues
 [ACCEPTABLE] Wrong password crash
 New Topic  Reply to Topic
 Printer Friendly
Author Previous Topic Topic Next Topic  

Hax

128 Posts

Posted - 08/03/2012 :  07:25:25  Show Profile  Reply with Quote
If the wrong (or blank) password is entered at startup, S+ will crash.

Rob

USA
2581 Posts

Posted - 08/03/2012 :  08:02:34  Show Profile  Visit Rob's Homepage  Reply with Quote
Does it crash or just fail to load stating the file couldn't be parsed?

The password isn't known to S+, it just attempts to use it to decrypt and load the xml, so if it's the wrong password, it simply falls into the logic for failing to parse the config as that's literally what has happened.
Go to Top of Page

Rob

USA
2581 Posts

Posted - 08/03/2012 :  08:29:57  Show Profile  Visit Rob's Homepage  Reply with Quote
...and it doesn't know whether it's encrypted or not, it just fails to parse and gives a chance to try decrypting, if that doesn't work then it assumes the file to be corrupt since that logic needs to remain in the event it's not encrypted but fails to parse.
Go to Top of Page

Hax

128 Posts

Posted - 08/03/2012 :  10:34:47  Show Profile  Reply with Quote
The 64-bit version of S+ crashes, the 32-bit version fails to load.
Go to Top of Page

Rob

USA
2581 Posts

Posted - 08/03/2012 :  10:45:26  Show Profile  Visit Rob's Homepage  Reply with Quote
Hmm, doesn't crash for me. Honestly, it's probably due to the contents of the file being sent into the XML parser with unexpected bytes which weren't decrypted properly (or at all when blank) and the parser itself is crashing, even though it's supposed to be caught as an exception.

I may not invest much time into this as long as it's fine with the correct password. I just wanted to add a simple protection scheme without spending a lot of time rewriting/restructuring the existing code. This change was a "drop-in-place" update, quick and dirty =)
Go to Top of Page
  Previous Topic Topic Next Topic  
 New Topic  Reply to Topic
 Printer Friendly
Jump To:
StrokesPlus Forum © 2011-2018 Rob Yapchanyk Go To Top Of Page
Snitz Forums 2000